Types: Export DecimationAlgorithm as const #9046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8993
This only affects the typescript compiler output of a typescript project consuming these types.
With
declare
, theDecimationAlgorithm
object is assumed to be found inchart.esm.js
, and its not, because we only have that in the '.d.ts'.As said in https://stackoverflow.com/a/50568865/10359775 the
const enum
is however replaced with the string values at compile time, so the end result does not try to useDecimationAlgorithm
from thechart.esm.js
, but uses the literal strings instead.More information: https://www.typescriptlang.org/docs/handbook/enums.html#enums-at-runtime