Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: Export UpdateModeEnum as const #10726

Merged
merged 1 commit into from Sep 30, 2022
Merged

Types: Export UpdateModeEnum as const #10726

merged 1 commit into from Sep 30, 2022

Conversation

lucianosantana
Copy link
Contributor

Allows a typescript project to consume UpdateModeEnum.

It is basically the same fix from #9046 applied to a different enum.

I'd consider this as an extended fix for #8993

@etimberg etimberg added the type: types Typescript type changes label Sep 30, 2022
@etimberg etimberg added this to the Version 4.0 milestone Sep 30, 2022
@etimberg etimberg merged commit 6f4b365 into chartjs:master Sep 30, 2022
@etimberg
Copy link
Member

etimberg commented Sep 30, 2022 •
edited

@kurkle I think we need to revert or fix this. It seems to be causing errors in #10728

@etimberg etimberg mentioned this pull request Sep 30, 2022
Merged
@kurkle
Copy link
Member

kurkle commented Oct 1, 2022

How could it be fixed? Reverting is ok by me.

@etimberg
Copy link
Member

etimberg commented Oct 1, 2022

Got it fixed in #10729. It needs to be export declare const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucianosantana @etimberg @kurkle