Fix detecting changed events #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `this._listeners` may contain both event handlers from options and internal event handlers for responsive support, the `setsEqual` check would often fail, causing event handlers to be unnecessarily detached and reattached and fired. If I'm understanding correctly, this is the root cause of chartjs#9049.
Correctly update events when responsive property changes as well as when requested events change.
|
No complains from a quick look. Might take a couple of days before I can give a through review. |
etimberg
reviewed
May 7, 2021
kurkle
reviewed
May 8, 2021
kurkle
approved these changes
May 10, 2021
etimberg
approved these changes
May 10, 2021
joshkel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
this._listenersmay contain both event handlers from options and internal event handlers for responsive support, thesetsEqualcheck would often fail, causing event handlers to be unnecessarily detached and reattached and fired.If I'm understanding correctly, this is the root cause of #9049.