Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detecting changed events #9050

Merged
merged 3 commits into from May 10, 2021
Merged

Fix detecting changed events #9050

merged 3 commits into from May 10, 2021

Commits on May 7, 2021

  1. Fix detecting changed events 

    Because `this._listeners` may contain both event handlers from options and internal event handlers for responsive support, the `setsEqual` check would often fail, causing event handlers to be unnecessarily detached and reattached and fired.

If I'm understanding correctly, this is the root cause of chartjs#9049.
    @joshkel
    joshkel committed May 7, 2021
    Configuration menu
    Copy the full SHA
    f12c076 View commit details
    Browse the repository at this point in the history

  2. Use a separate object for responsive listeners 

    Correctly update events when responsive property changes as well as when requested events change.
    @joshkel
    joshkel committed May 7, 2021
    Configuration menu
    Copy the full SHA
    3e31475 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Code review feedback

    @joshkel
    joshkel committed May 10, 2021
    Configuration menu
    Copy the full SHA
    af8c60f View commit details
    Browse the repository at this point in the history