Improved error message when no date adapter provided #9147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
reviewed
May 22, 2021
| @@ -8,7 +8,7 @@ | |||
| * @return {*} | |||
| */ | |||
| function abstract() { | |||
| throw new Error('This method is not implemented: either no adapter can be found or an incomplete integration was provided.'); | |||
| throw new Error('This method is not implemented: Check that a complete date adapter is provided.'); | |||
There was a problem hiding this comment.
Wouldnt it be better to use a variable for the type of adapter so that if in the future extra adapters are needed/added you dont have to change it again and can just pass that adapter name
There was a problem hiding this comment.
IMO that can be left for the future, trivial to update with a variable when its actually needed
kurkle
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9141