Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error message when no date adapter provided #9147

Merged
merged 1 commit into from May 22, 2021
Merged

Improved error message when no date adapter provided #9147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/core.adapters.js
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
* @return {*}
*/
function abstract() {
throw new Error('This method is not implemented: either no adapter can be found or an incomplete integration was provided.');
throw new Error('This method is not implemented: Check that a complete date adapter is provided.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldnt it be better to use a variable for the type of adapter so that if in the future extra adapters are needed/added you dont have to change it again and can just pass that adapter name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that can be left for the future, trivial to update with a variable when its actually needed

}

/**
Expand Down