Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offscreen canvas types #9617

Merged
merged 1 commit into from Sep 5, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Sep 4, 2021

Possible fix for #9594

An alternative is to add @types/offscreencanvas as a dependency. I wasn't sure we wanted to do that since we do not have any dependencies right now

@etimberg etimberg added the type: types Typescript type changes label Sep 4, 2021
@LeeLenaleee
Copy link
Collaborator

I think it might be better to add the @types/offscreencanvas as a dependency then because in the performance part of the docs the offscreencanvas is explained as an option and it would be weird if we document it but typing wont allow it.

@kurkle
Copy link
Member

kurkle commented Sep 4, 2021

I played around with adding the dependency, but could not get everything working with ts 4.4.2 unless library checking was diaabled. Maybe this is a good way for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants