Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radialLinear: fix getIndexAngle when there are no labels (left) #10020

Merged
merged 7 commits into from Dec 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/scales/scale.radialLinear.js
Expand Up @@ -371,8 +371,9 @@ export default class RadialLinearScale extends LinearScaleBase {
}

getIndexAngle(index) {
const angleMultiplier = TAU / this._pointLabels.length;
const angleMultiplier = TAU / (this._pointLabels.length || 1);
const startAngle = this.options.startAngle || 0;

return _normalizeAngle(index * angleMultiplier + toRadians(startAngle));
}

Expand Down
70 changes: 70 additions & 0 deletions test/fixtures/controller.polarArea/last-slice-animate.js
@@ -0,0 +1,70 @@
const canvas = document.createElement('canvas');
canvas.width = 512;
canvas.height = 512;
const ctx = canvas.getContext('2d');

module.exports = {
config: {
type: 'polarArea',
data: {
labels: ['A'],
datasets: [{
data: [20],
backgroundColor: 'red',
}]
},
options: {
animation: {
duration: 0,
easing: 'linear'
},
responsive: false,
plugins: {
legend: false,
title: false,
tooltip: false,
filler: false
},
scales: {
r: {
ticks: {
display: false,
}
}
}
},
},
options: {
canvas: {
height: 512,
width: 512
},
run: function(chart) {
chart.options.animation.duration = 8000;
chart.toggleDataVisibility(0);
chart.update();
const animator = Chart.animator;
// disable animator
const backup = animator._refresh;
animator._refresh = function() { };

return new Promise((resolve) => {
window.requestAnimationFrame(() => {
const anims = animator._getAnims(chart);
const start = anims.items[0]._start;
for (let i = 0; i < 16; i++) {
animator._update(start + i * 500);
let x = i % 4 * 128;
let y = Math.floor(i / 4) * 128;
ctx.drawImage(chart.canvas, x, y, 128, 128);
}
Chart.helpers.clearCanvas(chart.canvas);
chart.ctx.drawImage(canvas, 0, 0);

animator._refresh = backup;
resolve();
});
});
}
}
};
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.