Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve canvasGradient is undefined in node #10328

Merged
merged 5 commits into from May 3, 2022
Merged

Resolve canvasGradient is undefined in node #10328

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e1e028
Resolve canvasgradient is not defined in node
LeeLenaleee Apr 29, 2022
733fe22
Remove trailing white space
LeeLenaleee Apr 29, 2022
6a6270f
export isPaternOrGradient helper with typings
LeeLenaleee May 2, 2022
079f690
fix lint failure, single qoute
LeeLenaleee May 2, 2022
e6e9c94
Allow for string inputs too to function
LeeLenaleee May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/helpers/helpers.color.js
View file
Open in desktop
@@ -1,6 +1,13 @@
import colorLib from '@kurkle/color';

const isPatternOrGradient = (value) => value instanceof CanvasGradient || value instanceof CanvasPattern;
export function isPatternOrGradient(value) {
if (value && typeof value === 'object') {
const type = value.toString();
return type === '[object CanvasPattern]' || type === '[object CanvasGradient]';
}

return false;
}

export function color(value) {
return isPatternOrGradient(value) ? value : colorLib(value);
Expand Down
4 changes: 4 additions & 0 deletions types/helpers/helpers.color.d.ts
View file
Open in desktop
@@ -1,3 +1,5 @@
import { AnyObject } from '../basic';

export function color(value: CanvasGradient): CanvasGradient;
export function color(value: CanvasPattern): CanvasPattern;
export function color(
Expand All @@ -8,6 +10,8 @@ export function color(
| [number, number, number, number]
): ColorModel;

export function isPatternOrGradient(value: AnyObject): boolean;
LeeLenaleee marked this conversation as resolved.
Show resolved Hide resolved

export interface ColorModel {
rgbString(): string;
hexString(): string;
Expand Down