New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test(s) for Web #10563
Add integration test(s) for Web #10563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call this "react" or "react-browser" instead of "web" (in case we need to test different platforms)
Maybe we also want to remove the "package-lock.json" so we always test with latest? (the one from node project needs to be removed for sure) |
Not sure if removing package-lock.json is a good idea, then we can run into issues where the test fails because the lib updated. If an unexpected bug comes in and break things that should not break the tests. I reckon the chance is low this will happen but it might be worth considering. After seeying what happend with our own package lately and how it broke the helpers import. But removing it will indeed remove some maintance that will be caused because of needed updates. Not sure what is the better tradeoff |
I think the solution to the |
Resolve:
@LeeLenaleee can you add another (the one you described here: #10552 (comment))?
Originally posted by @kurkle in #10553 (comment)