Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid resize loop when browser zoom is set to 90% #10971

Merged
merged 10 commits into from Dec 17, 2022
Merged

fix: avoid resize loop when browser zoom is set to 90% #10971

merged 10 commits into from Dec 17, 2022

Commits on Dec 14, 2022

  1. test: new test to reproduce issue chartjs#10951

    @gbaron
    gbaron committed Dec 14, 2022
    Copy the full SHA
    10ea729 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge branch 'chartjs:master' into fix-10951

    @gbaron
    gbaron committed Dec 15, 2022
    Copy the full SHA
    7525e89 View commit details
    Browse the repository at this point in the history

  2. test: validate the canvas style too

    @gbaron
    gbaron committed Dec 15, 2022
    Copy the full SHA
    bf4fdcf View commit details
    Browse the repository at this point in the history

  3. fix: Avoid reassigning the the chart size. For specific values of pix… 

    …elRatio the assignment would cause the size to reduce by 1px. Since it's called from the ResizeObserver it will be stuck in a loop that constantly reduce the size of the chart and canvas.
    @gbaron
    gbaron committed Dec 15, 2022
    Copy the full SHA
    ed7a348 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'chartjs:master' into fix-10951

    @gbaron
    gbaron committed Dec 16, 2022
    Copy the full SHA
    3d10a16 View commit details
    Browse the repository at this point in the history

  2. Revert "fix: Avoid reassigning the the chart size. For specific value… 

    …s of pixelRatio the assignment would cause the size to reduce by 1px. Since it's called from the ResizeObserver it will be stuck in a loop that constantly reduce the size of the chart and canvas."

This reverts commit ed7a348.
    @gbaron
    gbaron committed Dec 16, 2022
    Copy the full SHA
    f70d6af View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. fix: Avoid the resize loop by fixing the rounding error in the retina… 

    …Scale function.
    @gbaron
    gbaron committed Dec 17, 2022
    Copy the full SHA
    23525ab View commit details
    Browse the repository at this point in the history

  2. fix: getMaximumSize was flooring non-integer height values unnecessar… 

    …ily.
    @gbaron
    gbaron committed Dec 17, 2022
    Copy the full SHA
    20b2475 View commit details
    Browse the repository at this point in the history

  3. Revert "fix: Avoid the resize loop by fixing the rounding error in th… 

    …e retinaScale function."

This reverts commit 23525ab.
    @gbaron
    gbaron committed Dec 17, 2022
    Copy the full SHA
    853ddb3 View commit details
    Browse the repository at this point in the history

  4. fix: Avoid the resize loop by fixing the rounding error in the retina… 

    …Scale function.
    @gbaron
    gbaron committed Dec 17, 2022
    Copy the full SHA
    1f21c67 View commit details
    Browse the repository at this point in the history