Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated type for doughnut offset #11051

Merged
merged 3 commits into from
Jan 13, 2023
Merged

fix: updated type for doughnut offset #11051

merged 3 commits into from
Jan 13, 2023

Conversation

mlankamp
Copy link
Contributor

Fixes #11050

@LeeLenaleee
Copy link
Collaborator

Docs will need an update too: https://www.chartjs.org/docs/4.1.2/charts/doughnut.html#dataset-properties

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Jan 12, 2023
@LeeLenaleee LeeLenaleee added this to the Version 4.2.0 milestone Jan 12, 2023
@mlankamp
Copy link
Contributor Author

Docs also updated

@kurkle kurkle merged commit 0e189dd into chartjs:master Jan 13, 2023
This was referenced May 26, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.2.0
Development

Successfully merging this pull request may close these issues.

Wrong typing for offset for Doughnut
4 participants
@mlankamp @LeeLenaleee @etimberg @kurkle