Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for isNaN before building number formatter options #11238

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Check for isNaN before building number formatter options #11238

merged 2 commits into from
Apr 19, 2023

Commits on Apr 19, 2023

  1. Check for isNaN before building number formatter options 

    When datasets have values approaching Number.MAX_VALUE, the tick calculations might result in infinity and eventually NaN. Passing NaN for minimumFractionDigits or maximumFractionDigits will make the number formatter throw. Instead we check for isNaN and use a fallback value so the formatter does not throw.
    @defunctzombie
    defunctzombie committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    38e1c18 View commit details
    Browse the repository at this point in the history

  2. Update src/core/core.ticks.js 

    Co-authored-by: Jacco van den Berg <jaccoberg2281@gmail.com>
    @defunctzombie @LeeLenaleee
    defunctzombie and LeeLenaleee committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9c482a7 View commit details
    Browse the repository at this point in the history