Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid tooltip truncation in x axis if there is enough space #3998

Merged
merged 6 commits into from Nov 11, 2017
Merged

Avoid tooltip truncation in x axis if there is enough space #3998

merged 6 commits into from Nov 11, 2017

Commits on Nov 9, 2017

  1. In tooltip x align calculation take into account caretSize 

    Truncation up to caretSize pixels could happen if label text produced tooltip element with size width:
* left side tooltip: width < x and width > x - caretSize
* right side tooltip: width < chartWidth - x and width > chartWidth - x - caretSize
Default caretSize = 5, so with default configuration truncation up to 5 pixels could happen.
    @kaidohallik
    kaidohallik committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    5616e98 View commit details
    Browse the repository at this point in the history

  2. avoid tooltip truncation if possible 

    use whole chart area for displaying tooltip
    @kaidohallik
    kaidohallik committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    6c1ca9e View commit details
    Browse the repository at this point in the history

  3. in xAlign calculation take into account caretPadding

    @kaidohallik
    kaidohallik committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    d800d4a View commit details
    Browse the repository at this point in the history

  4. add tests for tooltip truncation avoid logic

    @kaidohallik
    kaidohallik committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    ef18a57 View commit details
    Browse the repository at this point in the history

  5. use caretX instead of xCaret

    @kaidohallik
    kaidohallik committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    dd668a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. fix lint errors

    @kaidohallik
    kaidohallik committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    3cc7331 View commit details
    Browse the repository at this point in the history