Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onHover event not being triggered #4297

Merged
merged 2 commits into from May 28, 2017
Merged

Fix onHover event not being triggered #4297

merged 2 commits into from May 28, 2017

Commits on May 28, 2017

  1. Fix onHover event not being triggered 

    The core controller was looking at the wrong object (options.hover) to
find the function to be called on hover. The function is provided on the
top level options object (options.onHover).

Fixes #4296
    @ricardocosta
    ricardocosta committed May 28, 2017
    Configuration menu
    Copy the full SHA
    244c8ac View commit details
    Browse the repository at this point in the history

  2. Use helper function to invoke callback 

    By using the helper function, there's no need to verify if the callback
is defined, as the helper already does that.
    @ricardocosta
    ricardocosta committed May 28, 2017
    Configuration menu
    Copy the full SHA
    3551afe View commit details
    Browse the repository at this point in the history