Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable update #4362

Merged
merged 6 commits into from Jun 11, 2017
Merged

Support configurable update #4362

merged 6 commits into from Jun 11, 2017

Commits on Jun 10, 2017

  1. Support configurable update

    See discussion in the issue for context and possible approaches.
    
    When invoking update() inside an event handler, such as onHover,
    `options.hover.animationDuration` was not being respected. Given that
    some use cases may require additional animation properties for the
    manual update call, this commit changes that method signature to accept
    a configuration object.
    
    This object provides backwards compatibility with duration and lazy
    properties, and also introduces the easing property so that the event
    animation is different from the global one.
    
    Issue #4300
    ricardocosta committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    ae86fb9 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. Add test for core.controller#update

    Add tests that guarantee that when update is called manually with
    arguments, it properly builds the _bufferedRequest or calls render with
    the proper arguments.
    It includes test cases for when update is called with legacy arguments
    (duration and lazy) instead of the config object.
    
    Issue #4300
    ricardocosta committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    270286d View commit details
    Browse the repository at this point in the history
  2. Add missing documentation on .render() changes

    .update() documentation was previously updated but .render() was left
    out. Since the backwards compatible change was also made to render(),
    this commit adds documentation for it.
    
    Issue #4300
    ricardocosta committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    0db97cc View commit details
    Browse the repository at this point in the history
  3. Tests with focus on Chart.animationService#addAnimation

    Instead of relying on internal properties such as _bufferedRender and
    _bufferedRequest, the tests are now rewritten to focus on the parameters
    provided when calling Chart.animationService#addAnimation.
    
    The mention to the old signature of render and update was also removed
    from the docs.
    
    Issue #4300
    ricardocosta committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    bb6c771 View commit details
    Browse the repository at this point in the history
  4. Other small changes to specs

    - Use `this`
    - Do not use properties/data that are not needed for the spec.
    ricardocosta committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    fe2098d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5cb7b3f View commit details
    Browse the repository at this point in the history