Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to fix responsive chart size in IE11 when parent container has… #4620

Merged
merged 13 commits into from Apr 22, 2018
Merged

Update to fix responsive chart size in IE11 when parent container has… #4620

merged 13 commits into from Apr 22, 2018

Commits on Aug 7, 2017

  1. Update to fix responsive chart size in IE11 when parent container has… 

    … padding as percentage

When the chart is responsive to the parent container, the calculations for padding assumes that the figure is in pixels so that 20% is taken to be 20 (pixels), which results in the chart exceeding the parent container. This appears to be an IE11 only issue.
    @andi-b
    andi-b committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    ca9b1ae View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2017

  1. Updated code formating

    @andi-b
    andi-b committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    3d4fe3a View commit details
    Browse the repository at this point in the history

  2. Updated code formatting

    @andi-b
    andi-b committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    5528a61 View commit details
    Browse the repository at this point in the history

  3. Updated spaces to tabs

    @andi-b
    andi-b committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    26a56d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Added calculatePadding function 

    Added calculatePadding function to reduce code duplication
    @andi-b
    andi-b committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f31af0e View commit details
    Browse the repository at this point in the history

  2. Reduced code further 

    Reduced code further by adding to calculatePadding function
    @andi-b
    andi-b committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    52cdcce View commit details
    Browse the repository at this point in the history

  3. Updated to inline if statement 

    Fixed due to code climate:
Updated to inline if statement for single return
Removed space;
    @andi-b
    andi-b committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    083175b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Testing script added for calculatePadding function 

    Testing script added for calculatePadding function
    @andi-b
    andi-b committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4bfe92d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-1

    @andi-b
    andi-b committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    23b863c View commit details
    Browse the repository at this point in the history

  3. Update code formatting 

    Update code formatting as per Travis CI
    @andi-b
    andi-b committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    cd00af3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. Added variables and made function private 

    Added variable for clientWidth and clientHeight;
Made function calculatePadding private
    @andi-b
    andi-b committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    fedda5b View commit details
    Browse the repository at this point in the history

  2. Removed calls to private function 

    Removed calls to private function calculatePadding
    @andi-b
    andi-b committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    ec79652 View commit details
    Browse the repository at this point in the history

  3. Removed unused variable 

    Removed unused variable container
    @andi-b
    andi-b committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    76d0c0c View commit details
    Browse the repository at this point in the history