Allow dynamic bubble chart point styles #4665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
requested changes
Aug 17, 2017
| @@ -80,6 +80,7 @@ module.exports = function(Chart) { | |||
| y: reset ? yScale.getBasePixel() : yScale.getPixelForValue(data, index, dsIndex), | |||
| // Appearance | |||
| radius: reset ? 0 : custom.radius ? custom.radius : me.getRadius(data), | |||
| pointStyle: reset ? pointElementOptions.pointStyle : custom.pointStyle ? custom.pointStyle : helpers.getValueAtIndexOrDefault(dataset.pointStyle, index, pointElementOptions.pointStyle), | |||
There was a problem hiding this comment.
Does this use all the same point styles as the line chart? If so, there needs to be tests and documentation for this change
|
Since I was modifying the update of the bubble chart and rewriting the associated doc, I added this feature the same PR. |
|
Works for me. I'm not concerned about how it gets in, as long as I get to use it. |
|
Sounds good, would you mind to checkout my feature branch and test the associated PR? |
|
It's working with my use-cases. |
|
Implemented in #4671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubble charts did not allow setting the pointStyle attribute when updating a dataset.