Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock to Firefox 54 until Travis CI is fixed #4824

Closed
wants to merge 1 commit into from

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Oct 7, 2017

Try and get the tests to pass by forcing Travis to use Firefox 54 instead of the latest (56).

The tests seem to be failing with an error:

07 10 2017 13:55:53.062:WARN [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.
  Disconnected, because no message in 10000 ms.
Firefox 56.0.0 (Linux 0.0.0) ERROR

These tests pass fine locally with Firefox 56. This is likely related to travis-ci/travis-ci#8242

@simonbrunel
Copy link
Member

Per this comment, locking FF version doesn't work anymore (confirmed by this PR Travis build) :\

@etimberg
Copy link
Member Author

etimberg commented Oct 7, 2017

Another option is to remove Firefox and only test chrome. Not sure how good of an idea that is

@simonbrunel
Copy link
Member

The last merge didn't fail, not sure if it's a coincidence or if it fixes the Firefox issue.

@etimberg
Copy link
Member Author

etimberg commented Oct 7, 2017

hmmm, maybe it's related

@benmccann
Copy link
Contributor

I just sent a new PR and the build passed on it as well: #4826

I'm guessing the last merge may actually have solved the issue

@etimberg
Copy link
Member Author

etimberg commented Oct 8, 2017

Cool. I'll close this out then since it't not needed

@etimberg etimberg closed this Oct 8, 2017
@etimberg etimberg deleted the fix_firefox_build branch October 8, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants