Update moment #4956
Closed
Update moment #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chart.js doesn't use an old version of moment, |
|
Weird, it's not deduplicated in my case. Let me see what's the issue and reply back. |
|
That's because the change Simon referred to hasn't been included in a released version yet. The fix will be in Chart.js 2.8.0 |
|
I'm going to close this issue since it should be fixed when 2.8.0 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a minor change, but Chart.js using the old version of
momentprevents it from being deduplicated, resulting in bigger size of bundles (containing multiple versions ofmoment).