New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug #4202 #4971
Fix bug #4202 #4971
Conversation
@leonfed is there a way to unit test this? |
@etimberg I don't know how to make a unit test, because it's changes in visual look of charts. |
Closing due to inactivity |
Why has this been closed? This is a real issue that a lot of users experience. For example, I have many charts that show scores between 0 and 100. If the score reaches 100, the line gets clipped. I don't want to increase my y-axis to show a higher score, as no scores higher than 100 are possible. |
Adding my vote to reopen this pull request |
@etimberg Why close a real bug? |
@etimberg @simonbrunel Could you merge this, or at least review it? #4202 is still unfixed in 2.7.2. As @leonfed said, there isn't a clear way to unit test this, but that's no reason to close this without any further discussion. |
Okay, for anyone looking at this, #5321 was merged after 2.7.2, and claims to fix #4202. I still don't think this PR was handled appropriately. However, http://www.chartjs.org/dist/master/Chart.min.js as of right now still exhibits #4202. I don't know if that's outdated or if #4202 is still not entirely fixed (that file is different from https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.7.2/Chart.min.js, at least). |
These changes have been merged as part of #5321 but are not released yet. @lethosor it works with master (https://jsfiddle.net/e8n4xd4z/8951/) |
Fix bug #4202
Problem: line on the edge get cut
Example: https://jsfiddle.net/2tqmf2bg/
Pull request: https://jsfiddle.net/onnbzLuu/1/