Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip animation when target changes while animating #5005

Merged
merged 7 commits into from Dec 12, 2017
Merged

Fix tooltip animation when target changes while animating #5005

merged 7 commits into from Dec 12, 2017

Commits on Nov 29, 2017

  1. Fix issue chartjs#4989 

     - tooltip in 'index' mode doesn't animate smoothly.
    @jcopperfield
    jcopperfield committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    33a51ed View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2017

  1. Change: different approach for smooth tooltip animation in 'index' 

            mode, when target doesn't change.
    @jcopperfield
    jcopperfield committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    ce679dc View commit details
    Browse the repository at this point in the history

  2. Fix: jslint error

    @jcopperfield
    jcopperfield committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    982f0b4 View commit details
    Browse the repository at this point in the history

  3. Fix: remove spyOn pivot from test

    @jcopperfield
    jcopperfield committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    482e59f View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2017

  1. Add: setAnimating-flag in transition used to set on tooltip.transition 

         to keep track of tooltip animation.
    @jcopperfield
    jcopperfield committed Dec 3, 2017
    Configuration menu
    Copy the full SHA
    38574c3 View commit details
    Browse the repository at this point in the history

  2. Decrease code complexity

    @jcopperfield
    jcopperfield committed Dec 3, 2017
    Configuration menu
    Copy the full SHA
    f7d4d54 View commit details
    Browse the repository at this point in the history

  3. Revert transition and complexity changes 

    Add: use 'tooltip._start' as workaround check for tooltip animation status
    @jcopperfield
    jcopperfield committed Dec 3, 2017
    Configuration menu
    Copy the full SHA
    badc4d9 View commit details
    Browse the repository at this point in the history