Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating plugin options #5144

Merged
merged 1 commit into from Jan 13, 2018
Merged

Fix updating plugin options #5144

merged 1 commit into from Jan 13, 2018
+48 −1

Commits on Jan 13, 2018

  1. Fix updating plugin options 

    Cached plugin descriptors hold a reference on the plugin options, which break if the plugin options object is replaced. That case happens when the user updates the plugin options with a new object, but also since the new config update logic (chartjs#4198) that now always clones the plugin options. The fix consists in explicitly invalidating that cache before updating the chart.
    @simonbrunel
    simonbrunel committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    49d7e8f View commit details
    Browse the repository at this point in the history