Setup linter for HTML #5195
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,5 @@ extends: chartjs | |
| env: | ||
| browser: true | ||
| node: true | ||
|
|
||
| plugins: ['html'] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "indent-style": "tabs", | ||
| "attr-quote-style": "double", | ||
| "spec-char-escape": false, | ||
| "attr-bans": [ | ||
| "align", | ||
| "background", | ||
| "bgcolor", | ||
| "border", | ||
| "frameborder", | ||
| "longdesc", | ||
| "marginwidth", | ||
| "marginheight", | ||
| "scrolling" | ||
| ], | ||
| "tag-bans": [ "b", "i" ], | ||
| "id-class-style": false | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ var concat = require('gulp-concat'); | |
| var connect = require('gulp-connect'); | ||
| var eslint = require('gulp-eslint'); | ||
| var file = require('gulp-file'); | ||
| var insert = require('gulp-insert'); | ||
| var replace = require('gulp-replace'); | ||
| var size = require('gulp-size'); | ||
|
|
@@ -20,6 +19,7 @@ var collapse = require('bundle-collapser/plugin'); | |
| var yargs = require('yargs'); | ||
| var path = require('path'); | ||
| var fs = require('fs'); | ||
| var htmllint = require('gulp-htmllint'); | ||
| var package = require('./package.json'); | ||
|
|
||
| var argv = yargs | ||
|
|
@@ -49,9 +49,11 @@ gulp.task('bower', bowerTask); | |
| gulp.task('build', buildTask); | ||
| gulp.task('package', packageTask); | ||
| gulp.task('watch', watchTask); | ||
| gulp.task('lint', ['lint-html', 'lint-js']); | ||
| gulp.task('lint-html', lintHtmlTask); | ||
| gulp.task('lint-js', lintJsTask); | ||
| gulp.task('docs', docsTask); | ||
|
There was a problem hiding this comment. We should also remove the |
||
| gulp.task('test', ['lint', 'unittest']); | ||
| gulp.task('size', ['library-size', 'module-sizes']); | ||
| gulp.task('server', serverTask); | ||
| gulp.task('validHTML', validHTMLTask); | ||
|
|
@@ -153,11 +155,12 @@ function packageTask() { | |
| .pipe(gulp.dest(outDir)); | ||
| } | ||
|
|
||
| function lintJsTask() { | ||
| var files = [ | ||
| 'samples/**/*.html', | ||
| 'samples/**/*.js', | ||
| 'src/**/*.js', | ||
| 'test/**/*.js', | ||
| ]; | ||
|
|
||
| // NOTE(SB) codeclimate has 'complexity' and 'max-statements' eslint rules way too strict | ||
|
|
@@ -166,8 +169,8 @@ function lintTask() { | |
| var options = { | ||
| rules: { | ||
| 'complexity': [1, 10], | ||
| 'max-statements': [1, 30], | ||
| }, | ||
| }; | ||
|
|
||
| return gulp.src(files) | ||
|
|
@@ -176,6 +179,13 @@ function lintTask() { | |
| .pipe(eslint.failAfterError()); | ||
| } | ||
|
|
||
| function lintHtmlTask() { | ||
| return gulp.src('samples/**/*.html') | ||
| .pipe(htmllint({ | ||
| failOnError: true, | ||
| })); | ||
| } | ||
|
|
||
| function docsTask(done) { | ||
| const script = require.resolve('gitbook-cli/bin/gitbook.js'); | ||
| const cmd = process.execPath; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| globals: | ||
| $: true | ||
| Chart: true | ||
| Samples: true | ||
| moment: true | ||
| randomScalingFactor: true | ||
|
|
||
| rules: | ||
| no-new: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task should be ran as a dependency of the
linttask, nottest