Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect conversion of number to boolean #5209

Merged
merged 7 commits into from Jul 29, 2018
Merged

Incorrect conversion of number to boolean #5209

merged 7 commits into from Jul 29, 2018

Commits on Jan 30, 2018

  1. Incorrect conversion of number to boolean 

    Check for min/max/stepSize coerces numbers to truthy values. A min setting of 0 is therefore interpreted as not being set.

Checking against undefined means settings are correctly detected.
    @teroman
    teroman committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7a6183c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Update scale.linearbase.js

    @teroman
    teroman committed May 25, 2018
    Configuration menu
    Copy the full SHA
    2629677 View commit details
    Browse the repository at this point in the history

  2. Update scale.linear.tests.js

    @teroman
    teroman committed May 25, 2018
    Configuration menu
    Copy the full SHA
    fd7f051 View commit details
    Browse the repository at this point in the history

  3. Update scale.linear.tests.js

    @teroman
    teroman committed May 25, 2018
    Configuration menu
    Copy the full SHA
    a5740e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Update scale.linear.tests.js

    @teroman
    teroman committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    998840c View commit details
    Browse the repository at this point in the history

  2. Update scale.linear.tests.js

    @teroman
    teroman committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    b880921 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2018

  1. Update scale.linearbase.js 

    Good spot, I must have been on autopilot!
    @teroman
    teroman committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    a802fb1 View commit details
    Browse the repository at this point in the history