Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'angle' option to Polar Charts #5279

Merged
merged 9 commits into from Jun 17, 2018
Merged

Added 'angle' option to Polar Charts #5279

merged 9 commits into from Jun 17, 2018

Commits on Feb 18, 2018

  1. added 'angle' option to polar charts. image comparison test is work i… 

    …n progress; not currently passing
    Shayne Linhart committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    94bf815 View commit details
    Browse the repository at this point in the history

  2. removed unnecessary variable assignment

    Shayne Linhart committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    8c8b864 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. code cleanup based on PR; for 'angle' option on polarCharts

    Shayne Linhart committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    ff432f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Made polar chart image comparison test pass by removing debug flag. A… 

    …lso explicitly marked _computeAngle as private.
    Shayne Linhart committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    debbf75 View commit details
    Browse the repository at this point in the history

  2. Removed visibleCount computation in polar chart

    Shayne Linhart committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    3f1eb49 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. split out code related to updating the radius in polar chart's update… 

    … function, into it's own 'updateRadius' function
    Shayne Linhart committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    86419e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. made updateRadius method private

    Shayne Linhart committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    66e8e53 View commit details
    Browse the repository at this point in the history

  2. fix linting error

    Shayne Linhart committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    45d3bc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2018

  1. updated polar charts to read custom angles from "chart.options.elemen… 

    …ts.arc.angle" instead of "chart.options.angle"
    @slinhart
    slinhart committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    4a42e41 View commit details
    Browse the repository at this point in the history