Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legend appearance consistent with chart elements #5621

Merged
merged 6 commits into from May 9, 2019

Commits on May 7, 2019

  1. Make legend appearance consistent with chart elements

    - Use the default value for each element type if a property is not set
    - Stroke after fill to move borders to the front
    - Support indexable and scriptable options
    - Use point's colors and border width when usePointStyle is true
    - Disable line styles when usePointStyle is true or the dataset type is not 'line' or 'radar'
    - Add getStyle method to provide style properties for dataset or data
    - Fix the existing tests and add more tests
    nagix committed May 7, 2019
    Copy the full SHA
    0146168 View commit details
    Browse the repository at this point in the history
  2. Implement _resolveElementOptions in the base datasetController and re…

    …factor derived controllers
    nagix committed May 7, 2019
    Copy the full SHA
    9adc03f View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    7fa7e46 View commit details
    Browse the repository at this point in the history
  4. Further refactoring moving all _resolve*Options methods to the base c…

    …ontroller and renaming
    nagix committed May 7, 2019
    Copy the full SHA
    72ffd8a View commit details
    Browse the repository at this point in the history
  5. Fix typo

    nagix committed May 7, 2019
    Copy the full SHA
    9879c11 View commit details
    Browse the repository at this point in the history
  6. Small optimization

    nagix committed May 7, 2019
    Copy the full SHA
    66895ae View commit details
    Browse the repository at this point in the history