Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspectRatio property to responsive doc #5756

Merged
merged 5 commits into from Oct 9, 2018
Merged

Add aspectRatio property to responsive doc #5756

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab0f5f9
Add aspectRatio property to responsive doc
danielcb29 Oct 4, 2018
8bcffe6
Update aspectRatio type to Number instead of Integer
danielcb29 Oct 4, 2018
3475e6d
Removing parens from aspectRatio Default value
danielcb29 Oct 4, 2018
946f97b
Update aspectRatio setting description according PR feedback
danielcb29 Oct 8, 2018
8980254
Update aspectRatio description according new PR feedback
danielcb29 Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/general/responsive.md
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ Chart.js provides a [few options](#configuration-options) to enable responsivene
| `responsive` | `Boolean` | `true` | Resizes the chart canvas when its container does ([important note...](#important-note)).
| `responsiveAnimationDuration` | `Number` | `0` | Duration in milliseconds it takes to animate to new size after a resize event.
| `maintainAspectRatio` | `Boolean` | `true` | Maintain the original canvas aspect ratio `(width / height)` when resizing.
| `aspectRatio` | `Integer` | `(width / height)` | You can define your custom aspect ratio. If you want a 1:1 aspect ratio just set this property to 1. This doesn't work when you define a custom `width` and `height`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace Integer by Number since it can be 0.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, give a sec and I'll update it.

| `onResize` | `Function` | `null` | Called when a resize occurs. Gets passed two arguments: the chart instance and the new size.

## Important Note
Expand Down