Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointLabels padding #5873

Closed
wants to merge 5 commits into from
Closed

Conversation

ketysek
Copy link

@ketysek ketysek commented Nov 30, 2018

I've added pointLabels.padding settings option for radial charts to resolve the issue described here and attached in image bellow.

screen shot 2018-11-30 at 15 08 05

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New option should be documented.

Same issue is addressed in #5914, but these do not conflict.

src/scales/scale.radialLinear.js Show resolved Hide resolved
@kurkle
Copy link
Member

kurkle commented Dec 16, 2018

@ketysek could you create a test fiddle for this PR?

@ketysek
Copy link
Author

ketysek commented Dec 17, 2018

@kurkle
Copy link
Member

kurkle commented Dec 17, 2018

I think the padding should also be considered when calculating space needed (goes out the top with padding 50):
pad50

@nagix thoughts?

@nagix
Copy link
Contributor

nagix commented Dec 20, 2018

@ketysek #5914 fixed this issue, but do you still have any reason to add padding option?

@ketysek
Copy link
Author

ketysek commented Dec 21, 2018

@nagix if the issue will be fixed then this PR is not necessary :-)

@ketysek ketysek closed this Dec 21, 2018
@mrleblanc101
Copy link

This issue is not solved by #5914, points can still overlap the labels
Capture d’écran, le 2021-03-09 à 12 58 46

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

@mrleblanc101 can you provide a reproduce of that?

@mrleblanc101
Copy link

mrleblanc101 commented Mar 9, 2021

@kurkle Just created a CodeSanbox.
I use Vue-chartjs, but I'm sure it's not related.
I could reproduce in vanilla chart.js.
https://codesandbox.io/s/autumn-frog-bel26?file=/components/RadarChart.vue

@mrleblanc101
Copy link

Just tell me if this issue will be re-opened or if I should create a new issue.

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

I think opening a new issue would be good. Vanilla repro: https://codepen.io/kurkle/pen/qBqQqxa

@mrleblanc101
Copy link

@kurkle Thanks I just did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants