Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Browserify to rollup #5904

Merged
merged 1 commit into from Dec 14, 2018
Merged

Migrate from Browserify to rollup #5904

merged 1 commit into from Dec 14, 2018
+208 −124

Commits on Dec 12, 2018

  1. Migrate from Browserify to rollup 

    Browserify isn't optimal bundling Chart.js because it adds too many internal wrappers, doesn't handle external/global dependencies and doesn't provide a way to generate ESM builds. Therefore, it seems the right choice to switch to rollup, so move all the build process in `rollup.config.js` and make Gulp to execute `rollup -c`.

We also had to switch to Terser instead of UglifyJS because this last one contains a breaking bug. Note that tests now use the exact same rollup config as our builds (the minified one) to ensure that the bundling and minification steps don't break anything. Finally, replace the `gulp watch` task by `gulp build --watch` to be consistent with the other `unittest` and `docs` watching syntax.
    @simonbrunel
    simonbrunel committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3e43f98 View commit details
    Browse the repository at this point in the history