Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make moment optional from our UMD builds #5978

Merged
merged 5 commits into from Jan 29, 2019
Merged

Make moment optional from our UMD builds #5978

merged 5 commits into from Jan 29, 2019

Commits on Jan 29, 2019

  1. Make moment optional from our UMD builds 

    Create a rollup plugin altering the UMD header to wrap optional dependencies between try/catch, which allows to load moment only when the dependency is installed.

Since AMD loaders are asynchronous, `'moment'` needs to be explicitly loaded before 'chart.js' so when 'chart.js' requires moment, it's already loaded and returns synchronously (at least with requirejs).
    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    c8ab562 View commit details
    Browse the repository at this point in the history

  2. Change package.json CJS entry point

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    4b914be View commit details
    Browse the repository at this point in the history

  3. Add docs about excluding moment in Webpack/Rollup

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    891f7c5 View commit details
    Browse the repository at this point in the history

  4. Add a note about Moment.js in Require.js

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    3fac02d View commit details
    Browse the repository at this point in the history

  5. Update require.js note

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    91c877e View commit details
    Browse the repository at this point in the history