Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify time scale options in standard manner #6097

Merged
merged 4 commits into from Apr 2, 2019
Merged

Specify time scale options in standard manner #6097

merged 4 commits into from Apr 2, 2019

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 28, 2019 •
edited

It's difficult to write code that interfaces with the scale min and max options in a standard manner because the time scale puts the options in a different place than all the other scales, so everything has to be special cased to detect the time scale. This change allows reading from either the standard options.ticks location or the options.time location which this PR deprecates

kurkle
kurkle reviewed Mar 25, 2019
View reviewed changes
src/scales/scale.time.js Outdated Show resolved Hide resolved
kurkle
kurkle previously approved these changes Mar 25, 2019
View reviewed changes
etimberg
etimberg previously approved these changes Mar 25, 2019
View reviewed changes
nagix
nagix previously approved these changes Mar 26, 2019
View reviewed changes
simonbrunel
simonbrunel requested changes Mar 28, 2019
View reviewed changes
src/scales/scale.time.js Outdated Show resolved Hide resolved
src/scales/scale.time.js Outdated Show resolved Hide resolved
@benmccann benmccann dismissed stale reviews from nagix, etimberg, and kurkle via 244117f March 28, 2019 13:05
nagix
nagix reviewed Apr 1, 2019
View reviewed changes
src/scales/scale.time.js Outdated Show resolved Hide resolved
@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 1, 2019
simonbrunel
simonbrunel approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @benmccann

@simonbrunel simonbrunel merged commit a43e3b0 into chartjs:master Apr 2, 2019
@nagix nagix mentioned this pull request May 1, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Specify time scale min and max options in standard manner (chartjs#6097)
16c7457
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 6, 2022
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagix nagix nagix approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

@kurkle kurkle Awaiting requested review from kurkle

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benmccann @nagix @simonbrunel @etimberg @kurkle