Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early parse, stack by parsed value instead of index #6106

Closed
wants to merge 16 commits into from

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Mar 2, 2019

Experimental work. POC really. But I'm happy to alter this to a desired direction, if we can find one 😁

Pen (4997e7f)

Pen: data as object (4997e7f)

Fixes: #6103
Fixes: #5657
Fixes: #5405
Fixes: #5072
Closes: #6136

@benmccann
Copy link
Contributor

benmccann commented Mar 2, 2019

Also fixes #5657, #5484, #5405, #5072, #5139 ?

@benmccann
Copy link
Contributor

It looks like there's some potential overlap between this PR and #6056. I'd like to focus on getting that one in first since it's been open for a year. I think it's in a good state to merge and had approved it. There was a conflicting change checked in, so it will need to be rebased, but other than that it should be good to go.

@kurkle
Copy link
Member Author

kurkle commented Mar 2, 2019

Also fixes #5657, #5484, #5405, #5072, #5139 ?

Not #5458 or #5139 AFAIK

@kurkle
Copy link
Member Author

kurkle commented Mar 15, 2019

rebased to 2.8 and removed hard-coded scale id:s.
added some more charts to pen

@kurkle
Copy link
Member Author

kurkle commented Mar 16, 2019

Closing this as its only helpful to me at the moment. Will get back to this when I have a bigger picture figured out.

@kurkle kurkle closed this Mar 16, 2019
@attisan
Copy link

attisan commented Sep 17, 2019

as this seems to fix some major issues with time-stacked bar charts 😯 - what is needed for this to be in the master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment