Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the missing Chart.Chart (deprecated) alias #6112

Merged
merged 1 commit into from Mar 6, 2019
Merged

Fix the missing Chart.Chart (deprecated) alias #6112

merged 1 commit into from Mar 6, 2019

Conversation

simonbrunel
Copy link
Member

The Chart.Chart alias has been unintentionally removed in #5969 (existed at this line) but while debugging optional moment in Angular, I found that this alias is still in use.

// GOOD
import Chart from 'chart.js';

// WRONG
import { Chart } from 'chart.js';

@simonbrunel simonbrunel added this to the Version 2.8 milestone Mar 5, 2019
@simonbrunel simonbrunel merged commit 87a74f9 into chartjs:master Mar 6, 2019
@simonbrunel simonbrunel deleted the chore/chart.chart-alias branch March 6, 2019 08:12
@simonbrunel simonbrunel mentioned this pull request Mar 7, 2019
Merged
4 tasks
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@simonbrunel
Fix missing Chart.Chart (deprecated) alias (chartjs#6112)
545269b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@nagix nagix nagix approved these changes

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simonbrunel @benmccann @nagix @etimberg @kurkle