Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make line properties scriptable #6128

Merged
merged 29 commits into from Mar 21, 2019
Merged

Make line properties scriptable #6128

merged 29 commits into from Mar 21, 2019

Commits on Mar 10, 2019

  1. Initial line controller scriptable options.

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    6cb39a6 View commit details
    Browse the repository at this point in the history

  2. Adds backgroundColor tests.

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    9736257 View commit details
    Browse the repository at this point in the history

  3. Slight change to line-indexable backgroundColor.

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    fc9a2d7 View commit details
    Browse the repository at this point in the history

  4. Adds tests for borderColor

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    d9732bc View commit details
    Browse the repository at this point in the history

  5. Adds tests for borderWidth.

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    47604a8 View commit details
    Browse the repository at this point in the history

  6. Adds tests for boderCapStyle and a minor change to borderWidth test.

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    964edf6 View commit details
    Browse the repository at this point in the history

  7. Gets rid of indexable capability and tests

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    5a1d7d8 View commit details
    Browse the repository at this point in the history

  8. Adds remaining tests (borderDash, etc)

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    3dd557b View commit details
    Browse the repository at this point in the history

  9. Updates line doc

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    cadedf0 View commit details
    Browse the repository at this point in the history

  10. Updates scriptable line sample

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    5bbcb7a View commit details
    Browse the repository at this point in the history

  11. Updates 'should ignore invalid values' (fill test)

    @janelledement
    janelledement committed Mar 10, 2019
    Copy the full SHA
    99ef10e View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Gets rid of unnecessary LINE_OPTIONS var

    @janelledement
    janelledement committed Mar 11, 2019
    Copy the full SHA
    910e110 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Adds testing adjustment

    @janelledement
    janelledement committed Mar 12, 2019
    Copy the full SHA
    d6ef1f0 View commit details
    Browse the repository at this point in the history

  2. Updates test naming convention

    @janelledement
    janelledement committed Mar 12, 2019
    Copy the full SHA
    7bc4239 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Addresses root cause of fail tests

    @janelledement
    janelledement committed Mar 14, 2019
    Copy the full SHA
    c20f270 View commit details
    Browse the repository at this point in the history

  2. Removes a comment

    @janelledement
    janelledement committed Mar 14, 2019
    Copy the full SHA
    3281f89 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. Improves clarity of borderCapStyle tests/pngs.

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    fd338d7 View commit details
    Browse the repository at this point in the history

  2. Makes minor changes to line controller

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    219d84b View commit details
    Browse the repository at this point in the history

  3. Makes minor changes to scriptable sample chart

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    5103d26 View commit details
    Browse the repository at this point in the history

  4. Improves data for cubicInterpolationMode tests

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    91e6228 View commit details
    Browse the repository at this point in the history

  5. Adds padding and eliminates use of reduce in tests

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    40c602a View commit details
    Browse the repository at this point in the history

  6. Checks for ctx.dataIndex on appropriate tests

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    6f9429e View commit details
    Browse the repository at this point in the history

  7. Orders line options in tests alphabetically

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    76b9d09 View commit details
    Browse the repository at this point in the history

  8. Fixes minor lint errors

    @janelledement
    janelledement committed Mar 17, 2019
    Copy the full SHA
    1eb2a2c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Gets rid of grey color fill in borderCapStyle test

    @janelledement
    janelledement committed Mar 18, 2019
    Copy the full SHA
    bfcdd79 View commit details
    Browse the repository at this point in the history

  2. Keeps borderColor fallback in elements.point

    @janelledement
    janelledement committed Mar 18, 2019
    Copy the full SHA
    d2f8173 View commit details
    Browse the repository at this point in the history

  3. Adds fallback point borderColor/Width

    @janelledement
    janelledement committed Mar 18, 2019
    Copy the full SHA
    d9d1616 View commit details
    Browse the repository at this point in the history

  4. Makes adjustments to borderColor scriptable test

    @janelledement
    janelledement committed Mar 18, 2019
    Copy the full SHA
    54a0296 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Improves clarity for borderWidth scriptable test

    @janelledement
    janelledement committed Mar 19, 2019
    Copy the full SHA
    2a673d9 View commit details
    Browse the repository at this point in the history