Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement layers (z-index) for datasets #6262

Closed
wants to merge 5 commits into from

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented May 11, 2019

Resolves: #6050
Resolves: #5171

Pen

@kurkle kurkle changed the title Implement layers (z-index) for datasets WIP: Implement layers (z-index) for datasets May 11, 2019
@kurkle
Copy link
Member Author

kurkle commented May 11, 2019

Not quite sure where to document this feature.

@benmccann
Copy link
Contributor

The mixed charts docs are probably the only docs that talk about putting multiple datasets in a chart, so that might be the place to talk about the relative orderings?

Will the docs from #6241 also need to be updated? I.e. where it says Values < 0 are drawn under datasets, > 0 on top.

@kurkle kurkle changed the title WIP: Implement layers (z-index) for datasets Implement layers (z-index) for datasets May 11, 2019
@kurkle
Copy link
Member Author

kurkle commented May 11, 2019

Will the docs from #6241 also need to be updated? I.e. where it says Values < 0 are drawn under datasets, > 0 on top.

No, that still applies. This allows changing z-order between datasets (and allows multiple layers for dataset, but none such are implemented right now, line could draw points on a separate layer for example)

Filler plugin does not follow this z-order (it was changed to draw before all datasets).
It would need the new order, so maybe a getSortedVisibleDatasets or getSortedVisibleDatasetMetas should be made (as public).

@kurkle
Copy link
Member Author

kurkle commented May 11, 2019

After a short chat with @simonbrunel, going dataset.order route instead. Will PR that simpler solution another day.

@JorisDebonnet
Copy link

JorisDebonnet commented Aug 1, 2019

Just linking to the new issue here: #6268

(but unfortunately that one does not actually take care of the layer / z-index feature, but does something else)

@kurkle kurkle deleted the dataset-layers branch November 13, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to reverse render order of datasets Bar data overflow Line data
3 participants