Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html dom building #6490

Merged
merged 12 commits into from Sep 7, 2019
Merged

Html dom building #6490

merged 12 commits into from Sep 7, 2019

Commits on Aug 29, 2019

  1. replace HTML string array with DOM node creation for legendCallback

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    59a3eb1 View commit details
    Browse the repository at this point in the history

  2. fix: don't nest labels inside spans

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    5b3a13a View commit details
    Browse the repository at this point in the history

  3. replace HTML string array with DOM node creation for doughnut and pol… 

    …arArea legendCallback
    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    d9b24b4 View commit details
    Browse the repository at this point in the history

  4. suggestion: use for ul element variable, instead of for previous HTML… 

    … string version
    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    a9b1b01 View commit details
    Browse the repository at this point in the history

  5. Update documentation for generateLegend method; fix corresponding uni… 

    …t tests
    @benmccann
    dkoo authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    c20aa3e View commit details
    Browse the repository at this point in the history

  6. CR fix: Use DOM node constructors, but return HTML string for backwar… 

    …ds compatibility. Reverts test updates
    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    9dbaed5 View commit details
    Browse the repository at this point in the history

  7. Update unit test expected inline style spacing.

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    e5ad5f3 View commit details
    Browse the repository at this point in the history

  8. CR fixes: variable declaration, conditional and logic control formatting

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    6fe8ed9 View commit details
    Browse the repository at this point in the history

  9. add check for datasets values in doughnut and polar area

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    b547c1c View commit details
    Browse the repository at this point in the history

  10. declare variables at the top

    @ian-pvd @benmccann
    ian-pvd authored and benmccann committed Aug 29, 2019
    Copy the full SHA
    82aa7ee View commit details
    Browse the repository at this point in the history

  11. Ensure class is set when datasets is empty

    @benmccann
    benmccann committed Aug 29, 2019
    Copy the full SHA
    673bcc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Cache datasets

    @benmccann
    benmccann committed Sep 6, 2019
    Copy the full SHA
    736f96b View commit details
    Browse the repository at this point in the history