Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radar charts should fill to the center by default #7446

Merged
merged 2 commits into from
May 30, 2020
Merged

Radar charts should fill to the center by default #7446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53d175
Radar charts should fill to the center by default
etimberg May 30, 2020
1f1d6f2
Update tests for new defaults
etimberg May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/controllers/controller.radar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ defaults.set('radar', {
},
elements: {
line: {
fill: 'start',
tension: 0 // no bezier in radar
}
}
Expand Down
3 changes: 2 additions & 1 deletion test/fixtures/controller.radar/backgroundColor/scriptable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ module.exports = {
return index === 0 ? '#ff0000'
: index === 1 ? '#00ff00'
: '#ff00ff';
}
},
fill: true,
},
point: {
backgroundColor: '#0000ff',
Expand Down
3 changes: 2 additions & 1 deletion test/fixtures/controller.radar/backgroundColor/value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ module.exports = {
title: false,
elements: {
line: {
backgroundColor: '#00ff00'
backgroundColor: '#00ff00',
fill: true,
},
point: {
radius: 10
Expand Down
3 changes: 2 additions & 1 deletion test/fixtures/controller.radar/borderDash/scriptable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ module.exports = {
borderColor: '#00ff00',
borderDash: function(ctx) {
return ctx.datasetIndex === 0 ? [5] : [10];
}
},
fill: true,
},
point: {
radius: 10
Expand Down