Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML legend handles doughnut/pie charts #9044

Merged
merged 2 commits into from May 8, 2021
Merged

HTML legend handles doughnut/pie charts #9044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1eac80
HTML legend handles doughnut/pie charts
etimberg May 7, 2021
0ca9ea1
Fix lint error
etimberg May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/samples/legend/html.md
View file
Open in desktop
Expand Up @@ -45,7 +45,13 @@ const htmlLegendPlugin = {
li.style.marginLeft = '10px';

li.onclick = () => {
chart.setDatasetVisibility(item.datasetIndex, !chart.isDatasetVisible(item.datasetIndex));
const {type} = chart.config;
if (type === 'pie' || type === 'doughnut') {
// Pie and doughnut charts only have a single dataset and visibility is per item
chart.toggleDataVisibility(item.index);
} else {
chart.setDatasetVisibility(item.datasetIndex, !chart.isDatasetVisible(item.datasetIndex));
}
chart.update();
};

Expand Down