Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pointStyle types and update plugin link&render chart #9479

Merged
merged 2 commits into from Jul 30, 2021
Merged

Move pointStyle types and update plugin link&render chart #9479

merged 2 commits into from Jul 30, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

Comming from #9458, set the canvasElement on next line as type so table stays more readable and no scrollbar appears

kurkle
kurkle reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make a page (or a section In a generic Page) for the point style and link to it instead.

@LeeLenaleee LeeLenaleee changed the title Place canvasElement on next line to keep table clean Move pointStyle types and update plugin link/render chart Jul 29, 2021
@LeeLenaleee LeeLenaleee changed the title Move pointStyle types and update plugin link/render chart Move pointStyle types and update plugin link&render chart Jul 29, 2021
@LeeLenaleee
Copy link
Collaborator Author

afterDatasetsDraw hook in the renderFlorChart was missing and link naar plugin interface was dead because it seems case sensetive

@etimberg etimberg added this to the Version 3.5.1 milestone Jul 30, 2021
@etimberg etimberg merged commit f0a53fd into chartjs:master Jul 30, 2021
@LeeLenaleee LeeLenaleee deleted the docs/clean-table branch July 30, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 3.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeeLenaleee @kurkle @etimberg