Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleaning up metasets #9656

Merged
merged 4 commits into from Oct 23, 2021
Merged

Fix cleaning up metasets #9656

merged 4 commits into from Oct 23, 2021

Commits on Sep 16, 2021

  1. Fix cleaning up metasets 

    I believe it's a mistake to only delete the metaset if it has a valid controller; see f191f2f for where this behavior was introduced.

This is a minimal fix for chartjs#9653; as discussed there, it may also be worth updating `updateHoverStyle`.

As of chartjs#7030, `this._metasets` should always be defined, so checking whether it's undefined is no longer necessary.
    @joshkel
    joshkel committed Sep 16, 2021
    Copy the full SHA
    adceef9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Add a test covering metaset behavior

    @joshkel
    joshkel committed Oct 13, 2021
    Copy the full SHA
    44094c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Add a regression test for chartjs#9653; fix toHaveSize usage

    @joshkel
    joshkel committed Oct 14, 2021
    Copy the full SHA
    e27bdec View commit details
    Browse the repository at this point in the history

  2. Fix test failure

    @joshkel
    joshkel committed Oct 14, 2021
    Copy the full SHA
    e030d61 View commit details
    Browse the repository at this point in the history