Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache also undefined values in option resolver #9661

Merged
merged 1 commit into from Oct 4, 2021

Commits on Sep 19, 2021

  1. cache also undefined values in option resolver

    Otherwise, repeated lookups of undefined properties always trigger the
    comparatively expensive resolution. This can be the case for example in
    _calculateBarIndexPixels() in controller.bar.js when looking up
    options.skipNull and options.maxBarThickness, which is done for each bar
    in a bar chart.
    Flupp committed Sep 19, 2021
    Copy the full SHA
    7e2855e View commit details
    Browse the repository at this point in the history