Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed var to const/let in the docs #9743

Closed
wants to merge 4 commits into from
Closed

Changed var to const/let in the docs #9743

wants to merge 4 commits into from

Conversation

Prashoon123
Copy link
Contributor

In the docs, I have changed var to const/let because using var is considered a bad practice in JavaScript(when it's not needed).

@etimberg
Copy link
Member

etimberg commented Oct 8, 2021

It looks like the markdown files got reformatted. I don't think we can accept this change as is due to the size

@Prashoon123
Copy link
Contributor Author

It looks like the markdown files got reformatted. I don't think we can accept this change as is due to the size

Oh, what can I do to fix this?

@Prashoon123
Copy link
Contributor Author

Prashoon123 commented Oct 8, 2021

It looks like the markdown files got reformatted. I don't think we can accept this change as is due to the size

Oh, what can I do to fix this?

But everything seems to be working perfectly in the development server.
image

@etimberg
Copy link
Member

etimberg commented Oct 8, 2021

Are you able to remove the automatic reformatting and just keep the const/let changes?

@Prashoon123
Copy link
Contributor Author

Prashoon123 commented Oct 8, 2021

Are you able to remove the automatic reformatting and just keep the const/let changes?

I will try my best!

@Prashoon123
Copy link
Contributor Author

@etimberg there was some problem with this PR so I created a new PR where I have fixed everything. Here is the link to the PR - #9744

@Prashoon123 Prashoon123 closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants