Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to tooltip positioners #9944

Merged
merged 6 commits into from Dec 6, 2021
Merged

Improvements to tooltip positioners #9944

merged 6 commits into from Dec 6, 2021

Commits on Dec 2, 2021

  1. Improve positioner types; allow overriding xAlign and yAlign

    @joshkel
    joshkel committed Dec 2, 2021
    Copy the full SHA
    6a63b54 View commit details
    Browse the repository at this point in the history

  2. More type improvements; pass in Chart as third parameter

    @joshkel
    joshkel committed Dec 2, 2021
    Copy the full SHA
    9de760e View commit details
    Browse the repository at this point in the history

  3. Expose chart as part of TooltipModel 

    I initially passed the Chart element as the third parameter to the positioner; however, Scale and LegendElement elements expose `this.chart`, and sample code for positioners used `this._chart`, so documenting the chart member and giving it a public name seems to make more sense.
    @joshkel
    joshkel committed Dec 2, 2021
    Copy the full SHA
    a2702be View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Update documentation

    @joshkel
    joshkel committed Dec 3, 2021
    Copy the full SHA
    8205195 View commit details
    Browse the repository at this point in the history

  2. Fix documentation

    @joshkel
    joshkel committed Dec 3, 2021
    Copy the full SHA
    8e845b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Fix issues from code review

    @joshkel
    joshkel committed Dec 5, 2021
    Copy the full SHA
    489b454 View commit details
    Browse the repository at this point in the history