Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Luxon supported options documentation to README #53

Merged
merged 6 commits into from
Apr 3, 2022

Conversation

stockiNail
Copy link
Contributor

This PR is adding documentation about which options can be set to configure Luxon.

As reported by PR #42 and issue #46, these could not be well-known.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2033284960

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.727%

Totals Coverage Status
Change from base Build 1660678495: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 24, 2022

Pull Request Test Coverage Report for Build 2033284960

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.727%

Totals Coverage Status
Change from base Build 1660678495: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
stockiNail and others added 4 commits March 24, 2022 16:33
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@stockiNail
Copy link
Contributor Author

@benmccann thank you very much for your review. My English is not so good! I have changed INTL to Intl also in the other options description where it was used.

@benmccann
Copy link
Collaborator

thank you! looks like a nice change. I can't merge, so will need to wait for someone else for that

@kurkle kurkle merged commit da55c17 into chartjs:master Apr 3, 2022
@stockiNail stockiNail deleted the addOptions branch July 11, 2022 08:31
@kurkle kurkle added this to the 1.2.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants