Fix: Honor zoom.mode (xy/x/y) when applying zoom.threshold. Don't trigger zoom outside the area of chart lines/bars. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2020 00:06
If user starts mouse down for example in area of legends or axis the zoom starts. This fix limits the starting of zooming to the area of the actual graph. Fixes chartjs#256
ikkala
changed the title
added 2 commits
May 8, 2020 01:32
|
Sorry, didn't mean to include the commit 8c0b0d3 (0.7.8: Patched 0.7.7) here into pull request -- it was only for internal testing. |
|
Great news ! Thank you. |
kurkle
reviewed
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had case where options.zoom.mode was set to 'x' and threshold was set. The mouse dragging vertically was still triggering the zoom, even without exceeding the threshold.
If user starts mouse down for example in area of legends or axis the zoom starts. This fix limits the starting of zooming to the area of the actual graph.
Fixes #256