Fix drag rectangle calculation when inside shadow BOM / WebComponent #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edges of the drag rectangle were calculated incorrectly when the chart is placed inside a shadow BOM (eg. inside a web component). Chart.js itself already has fixes for that (see PRs #7225 and #8082). Its getRelativePosition() function always returns the correct coordinates. So import and use this function from Chart.js.
hugo-valcourt
approved these changes
Feb 23, 2023
kurkle
approved these changes
Mar 1, 2023
|
CI fails because of FF, fix is same as in Chart.js: https://github.com/chartjs/Chart.js/pull/11165/files |
|
getRelativePosition seems to give the wrong position when mouseup occurs over a different element (as when a drag ends outside the chart canvas), which is causing the regression in #770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726.
The edges of the drag rectangle were calculated incorrectly when the chart is placed inside a shadow BOM (eg. inside a web component). Chart.js itself already has fixes for that (see Chart.js PRs). Its getRelativePosition() function always returns the correct coordinates.
So import and use this function from Chart.js.