Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "original" scale limits with nonlinear pan #774

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Jul 25, 2023

  1. Add some JSDoc types

    These currently raise spurious errors, due to limitations in Chart.js types.
    joshkel committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    423f7ee View commit details
    Browse the repository at this point in the history
  2. Fix handling of "original" with panning nonlinear scales

    Nonlinear scales failed to resolve "original" within panNumericalScale.
    
    To fix this:
    
    * Resolving "original" within panNumericalScale seemed redundant, when
      updateRange was already doing it, so I instead moved the logic into
      updateRange and control it with a new special value for the `zoom`
      parameter.  (Hopefully the use of a special string like this is
      acceptable as long as JSDoc calls it out - if I should use another
      approach, please let me know.)
    * This change put updateRange over the configured ESLint complexity
      limit, so I extracted a new getScaleLimits function to reduce
      complexity.
    
    Add unit tests, both for this bug and for the preexisting but untested
    "original" feature.
    joshkel committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1ce98cb View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    792c48f View commit details
    Browse the repository at this point in the history