Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VuePress to VitePress #809

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

bavoco
Copy link

@bavoco bavoco commented Mar 11, 2024

This reduces the number of dev dependencies by about 700.

Towards #812

@bavoco bavoco marked this pull request as draft March 11, 2024 22:18
@bavoco bavoco mentioned this pull request Mar 17, 2024
4 tasks
@bavoco bavoco marked this pull request as ready for review March 17, 2024 19:59
@NotTsunami
Copy link

By nature, the move from VuePress -> VitePress should also allow us to drop the babel dependencies too, right? A very brief peek at the source suggests it is not used outside of VuePress.

@NotTsunami
Copy link

I tested it on your branch and npm run docs passes with the babel dependencies removed. With @babel/core, @babel/preset-env, and babel-loader removed, another 155 packages are removed. npm run test passes with 76/76 tests while npm run lint and npm run build complete without error.

@NotTsunami
Copy link

NotTsunami commented Apr 10, 2024

You should be able to remove ng-hammerjs as well, since it was only used in VuePress:

// Hammerjs requires window, using ng-hammerjs instead
'hammerjs': 'ng-hammerjs',

@bavoco
Copy link
Author

bavoco commented Apr 11, 2024

Great! If #808 gets merged there won't be two versions of Rollup and related plugins further reducing the count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants