-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new onboarding #9066
Closed
Closed
feat: new onboarding #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Adds onboarding views after signup * Updates i18n strings * Review fixes * feat: Adds assets used in the onboarding pages (#8935) * feats: Adds assets used in the onboarding pages * Adds icons and translations * Update app/javascript/dashboard/i18n/locale/en/signup.json * Updates locale string * Review fixes * Fixes layout on large and extra large screens * Reverts unwanted changes * Fixes styles on signup page * Adds signup page APIs * Update app/javascript/dashboard/routes/index.js * Updates signup page
* feat: Adds steps to show onboarding view after signup * Updates routes * Review fixes * chore: Adds helpers needed for onboarding views (#8937) * chore: Adds helpers needed for onboarding views * Update OnboardingHelper.js * Update OnboardingHelper.spec.js * Update BrowserHelper.spec.js * Update app/javascript/v3/helpers/BrowserHelper.js Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> * Update app/javascript/v3/helpers/OnboardingHelper.js Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> * Updates helper * Update app/javascript/dashboard/constants/globals.js * Update app/javascript/v3/helpers/BrowserHelper.js * Update app/javascript/v3/helpers/specs/BrowserHelper.spec.js * Adds case for handling empty values * Lint error fixes --------- Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> --------- Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
…t into feat/onboarding-cw-2667
This reverts commit 898376c.
iamsivin
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scmmishra Please take a look at the comments.
|
🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild? |
Closing for now, will re-open if required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2024-03-08.at.16.08.19.mp4
Fixes https://linear.app/chatwoot/issue/CW-2887/onboarding-ui